z-huang / InnerTune

A Material 3 YouTube Music client for Android
GNU General Public License v3.0
4.3k stars 266 forks source link

Album and Playlists API Changes #1295

Closed AbuTar closed 2 months ago

AbuTar commented 3 months ago

Checklist

Steps to reproduce the bug

Open Innertune Press on Account Select a Playlist

Expected behavior

Playlists load and I can download, add to queue, save to playlist etc....

Actual behavior

The playlist doesn't load and I can't do anything

Screenshots/Screen recordings

image

Logs

gxh

InnerTune version

0.5.3

Android version

14

Additional information

No response

BioTheHuman commented 3 months ago

Yep, same.

I can't sync or import new playlists.

Still able to play a playlist already downloaded though

Richard38907 commented 3 months ago

Same here. I tested on several yt music streaming apps, impossible to load these pages anymore since yesterday. There are a lot of comments about it.

You can use New Pipe at the moment to play them, it works for me.

https://newpipe.net/#download

Just share the playlist from yt music with new pipe and the playlist will appear.

1seco commented 3 months ago

Happens in other situations too. Going to an artist's account, and tapping the arrow to see more albums (or anything else for that matter) causes this problem, and nothing is loading, nor I see any network traffic (shown through a setting on my phone, updated ev sec.), instead one has to know the album name beforehand to search, maybe an inital ~4-6kb incoming data and nothing later. Screenshot_20240622-162253_InnerTune_1

Cropped image of attempting to find more albums from an artist

Malopieds commented 3 months ago

Hi all, youtube updated their api, that's why. I'm currently working on a fix. I have successfully fixed the albums and playlists not loading. Have you seen this bug anywhere else?

Edit: Maybe change the title to something more explicit since it's not an import issue

AbuTar commented 3 months ago

Any ideas for a better title? Youtube API issue etc....

Malopieds commented 3 months ago

Any ideas for a better title? Youtube API issue etc....

What about Album and Playlists API changes?

AbuTar commented 3 months ago

Ok got it

Any ideas for a better title? Youtube API issue etc....

What about Album and Playlists API changes?

Deemitry88 commented 3 months ago

Will you push and release the update soon ? I wanted to show the app to a friend

Malopieds commented 3 months ago

Will you push and release the update soon ? I wanted to show the app to a friend

It's already pushed, I will try to release later today if I have time or tomorrow. If you just want to show it to a friend you can download this version (it's a bit more laggy because it's debug)

AbuTar commented 3 months ago

Will you push and release the update soon ? I wanted to show the app to a friend

It's already pushed, I will try to release later today if I have time or tomorrow. If you just want to show it to a friend you can download this version (it's a bit more laggy because it's debug)

Thanks for the hard work; I've been using the app as my go-to Spotify alternative. I'm interested though how you're able to roll out updates so quickly; I'm getting better at coding rn (start uni next year) and it seems like a very short amount of time spent on what seems like a big issue

Malopieds commented 3 months ago

I'm interested though how you're able to roll out updates so quickly; I'm getting better at coding rn (start uni next year) and it seems like a very short amount of time spent on what seems like a big issue

I'm finishing my third year of computer science in a 5 year diploma, but doing side project is what gets you more experience imo. But it's not always easy to do both at the same time. This issue was not that big, it can seems huge because of the size of the json sent from youtube music, but the more you deal with it, the "easier" it gets (even though it's never fun, they're doing everything they can to stop people from using third party apps)

Anyway, here is the link for the latest version.

AbuTar commented 3 months ago

Thanks! Hope everything goes well

AbuTar commented 3 months ago

Liked songs work for me now but my other playlists still aren't loading

Malopieds commented 3 months ago

Liked songs work for me now but my other playlists still aren't loading

You mean Top playlist and offline playlists? Or playlist you made yourself? Both are working for me, if you have screenshot/if you want to open issue in my repo

AbuTar commented 3 months ago

Liked songs work for me now but my other playlists still aren't loading

You mean Top playlist and offline playlists? Or playlist you made yourself? Both are working for me, if you have screenshot/if you want to open issue in my repo

Playlists I've made in youtube music (besides my liked songs), for example nina Mix won't play ( A playlist made in yt music) but liked songs does work Screenshot_20240622_204543_InnerTune Screenshot_20240622_204527_InnerTune Screenshot_20240622_204520_InnerTune

Malopieds commented 3 months ago

Playlists I've made in youtube music (besides my liked songs), for example nina Mix won't play ( A playlist made in yt music) but liked songs does work

Oh you mean the one linked to your account? Yeah I haven't thought of those ones since I don't use google. I'll make sure to correct this

AbuTar commented 3 months ago

Thanks! It doesn't have to be immediate though, I'm OK with just my liked songs for a while. Feel free to take your time

YUG38 commented 3 months ago

Playlists I've made in youtube music (besides my liked songs), for example nina Mix won't play ( A playlist made in yt music) but liked songs does work

Oh you mean the one linked to your account? Yeah I haven't thought of those ones since I don't use google. I'll make sure to correct this

Do you know when you will be done with fixing that?

Germsicle commented 3 months ago

Checklist

  • [x] I am able to reproduce the bug with the latest debug version.
  • [x] I've checked that there is no open or closed issue about this bug.
  • [x] This issue contains only one bug.
  • [x] The title of this issue accurately describes the bug.

Steps to reproduce the bug

Open Innertune Press on Account Select a Playlist

Expected behavior

Playlists load and I can download, add to queue, save to playlist etc....

Actual behavior

The playlist doesn't load and I can't do anything

Screenshots/Screen recordings

image

Logs

gxh

InnerTune version

0.5.3

Android version

14

Additional information

No response

Same issue here....came here to check if it's been reported. Thanks OP

Germsicle commented 3 months ago

I had originally downloaded through droidify and didn't realize it was a much different version! I discovered the backup and restore option and decided to fresh install through github and WOWZERS! Totally different home screen than the droidify version, plus the bug fix woo! You have been busy and i LOVE this newer version even more! You rock!!! Thanks for all your work! Love this app!

Malopieds commented 3 months ago

Do you know when you will be done with fixing that?

This is now fixed.

Will this update be sent to droidify?

I don't handle that.

I downloaded your fix but when installing it says cannot install due to conflicting api package with my guess that it has to be updated through droidify itself?

F-Droid are building the packages with their keys iirc, and since F-Droid and I don't have the same key, long story short you can't.

I don't want to uninstall and lose all my settings and improted playlists etc :/ thanks for all your work! Love this app!

You can export them, it should save the playlists and settings (just not the downloaded songs). If you have another phone/emulator you can try to see if everything works well (there should be no problem if you export your data in the settings => backup and restore) .

In addition, to have an update on F-Droid you must have one from this repo and not mine. Plus F-Droid repos take some time to update, it's often better to take them directly from github or use apps that fetch it for you, for example Obtainium.

Germsicle commented 3 months ago

Oops I just updated my comment didn't realize you would respond so fast 🤗 all good! Thanks a million

AbuTar commented 3 months ago

Is this the top apk the one that's gully fixed Screenshot_20240623_093946_Chrome

Malopieds commented 3 months ago

Oops I just updated my comment didn't realize you would respond so fast 🤗 all good! Thanks a million

Haha no problem !

Is this the top apk the one that's gully fixed

Yep, I wrote it in the Edit !

d4f5409d commented 3 months ago

@Malopieds can you add yours to Izzyondroid repo?

AbuTar commented 3 months ago

Oops I just updated my comment didn't realize you would respond so fast 🤗 all good! Thanks a million

Haha no problem !

Is this the top apk the one that's gully fixed

Yep, I wrote it in the Edit !

Thanks a ton! Can I mark this issue as done now?

Malopieds commented 3 months ago

@Malopieds can you add yours to Izzyondroid repo?

I don't do this, I think it has to be the maintainer of izzy to do this. But since the package is the same I don't think he would.

Can I mark this issue as done now?

No, since it's not resolved here

MehRad13 commented 3 months ago

I also have playlists issue. IT only shows the Album of the song I downloaded or seen, but doesn't show the album if didn't download it, played it or seen it.

Screenshot_20240623-142039 Screenshot_20240623-142046

wglee99 commented 3 months ago

I also have playlists issue. IT only shows the Album of the song I downloaded or seen, but doesn't show the album if didn't download it, played it or seen it.

Screenshot_20240623-142039 Screenshot_20240623-142046

Hello! @Malopieds has fixed the issue in his fork and released a working version I presume. Do check out his version! On a side note, @Malopieds would you mind going into a little more detail regarding the API changes from Youtube and the changes you made to the code (for educational purposes)? Appreciate it!

d4f5409d commented 3 months ago

@Malopieds can you add yours to Izzyondroid repo?

I don't do this, I think it has to be the maintainer of izzy to do this. But since the package is the same I don't think he would.

I think you have to get in touch with izzy. I am not sure how this works, but izzy's repo is different from F-Droid, not so strict. @IzzySoft I am sure you could resolve this, the app is in need of updates. Currently it's broken and unusable. I guess @z-huang doesn't have the time anymore to do it, so it's a blessing you could do the work.

Malopieds commented 3 months ago

On a side note, @Malopieds would you mind going into a little more detail regarding the API changes from Youtube and the changes you made to the code (for educational purposes)? Appreciate it!

I started a discussion on my repo, feel free to ask questions there

I think you have to get in touch with izzy. I am not sure how this works, but izzy's repo is different from F-Droid, not so strict. @IzzySoft I am sure you could resolve this, the app is in need of updates. Currently it's broken and unusable. I guess @z-huang doesn't have the time anymore to do it, so it's a blessing you could do the work.

Let's see

d4f5409d commented 3 months ago

@Malopieds thank you in advance, our hero. 🫡

IzzySoft commented 3 months ago

can you add yours to Izzyondroid repo?

Huh? Why? Why "add it"? It is there for more than 2 years already (since 2022-04-09). What do I miss here?

YUG38 commented 3 months ago

@IzzySoft I think that person is talking about @Malopieds's repo not this repo

IzzySoft commented 3 months ago

Ah – sorry, had no time to follow the entire thread. Specific question then please :wink:

Malopieds commented 3 months ago

Ah – sorry, had no time to follow the entire thread. Specific question then please 😉

I opened an issue on my repo for more clarity !

Nitin927 commented 3 months ago

Album are not opening

YUG38 commented 3 months ago

@Nitin927 are you using @Malopieds's forked version?

7heMech commented 3 months ago

Hey, is there a way to update f-droid, sorry if you talked about that, I didn't read everything.

Germsicle commented 3 months ago

Hey, is there a way to update f-droid, sorry if you talked about that, I didn't read everything.

Yeah they answered it... they don't control fdroid so no. But you can backup your settings and install the updated version above

mikwee commented 3 months ago

Albums that aren't hearted still don't open on @Malopieds's version

Malopieds commented 3 months ago

Albums that aren't hearted still don't open on @Malopieds's version

I can assure you it does work. Please use the right version (the pre-release one, fix-login).

mikwee commented 3 months ago

@Malopieds Thanks. For future reference, the fix-login APK is inside v0.5.7-rc2.

7heMech commented 3 months ago

Albums that aren't hearted still don't open on @Malopieds's version

I can assure you it does work. Please use the right version (the pre-release one, fix-login).

It works does crash sometimes, but does work 👍

Malopieds commented 3 months ago

It works does crash sometimes

How so? Could you fill an issue in my repo maybe?

7heMech commented 3 months ago

It works does crash sometimes

How so? Could you fill an issue in my repo maybe?

Well for example when you swipe it away on the apps screen, or when you put a sleep timer and turn of screen after a minute it stops playing (bit doesn't crash) and can't play anymore.

Malopieds commented 3 months ago

@7heMech please open an issue on my repo with logs and screenshots/scresnrecord otherwise I can't and won't help.

Henry-Hiles commented 2 months ago

Any chance of the fix being upstreamed?

d4f5409d commented 2 months ago

Any chance of the fix being upstreamed?

Barely any. Only if @z-huang becomes available online.

7heMech commented 2 months ago

Any chance of the fix being upstreamed?

Barely any. Only if @z-huang becomes available online.

If you open his profile you can see 4th of July commit in private repo