z-huang / InnerTune

A Material 3 YouTube Music client for Android
GNU General Public License v3.0
4.19k stars 261 forks source link

One Library tab #1545

Open pdimu opened 2 weeks ago

pdimu commented 2 weeks ago

Checklist

Feature description

All the 'Songs', 'Artist', 'Albums' tabs should be merged into just one tab: "Library" In the library, 'Songs', 'Albums' and 'Artists' will be separated with this type of tabs (image) I don't know if this interferes with the sort pills though

Why do you want this feature?

The bottom tabs are taking up very much space and this would be a good fix

Additional information

Screenshot_2024-09-03-23-12-11-226-edit_com google android keep This type of tabs in the big library tab

z-huang commented 2 weeks ago

I've been questioning the usefulness of the integrated library tab. I don't know why many apps are migrating to this style, including YTM and Spotify. You need to click twice, one for the library tab, the other for the filter chip, to reach your destination. Even three if you want to change the filter. This is also not friendly when you use your phone with only one hand.

The bottom tabs are taking up very much space and this would be a good fix

Five is totally tolerable, and material design suggests 3-5 items in the navigation bar. Reducing navigation bar items to only "Home" and "Library" makes the bottom of the screen look visually hollow, I've tried.

pdimu commented 2 weeks ago

The Playlists tab can be kept at its place, as it's not related to Library

ThatOneUnoriginal commented 2 weeks ago

Five is totally tolerable, and material design suggests 3-5 items in the navigation bar. Reducing navigation bar items to only "Home" and "Library" makes the bottom of the screen look visually hollow, I've tried.

This isn't entirely related to the original feature request but I have an alternative suggestion; How about a system that would allow you to remove categories from the bottom bar entirely. I have a large playlist that I almost entirely exclusively listen to so I have little to no reason to check out the artists or songs sections and not much more reason to check out the albums section. So an option to disable those from appearing on the bottom bar would make things cleaner (whilst still allowing those who do want those to still have them.)

Also you could add an explore section like Malopied has done with their forked version of the application if only having two tabs feels too empty. Screenshot_20240904-161848.png

pdimu commented 2 weeks ago

Five is totally tolerable, and material design suggests 3-5 items in the navigation bar. Reducing navigation bar items to only "Home" and "Library" makes the bottom of the screen look visually hollow, I've tried.

This isn't entirely related to the original feature request but I have an alternative suggestion; How about a system that would allow you to remove categories from the bottom bar entirely. I have a large playlist that I almost entirely exclusively listen to so I have little to no reason to check out the artists or songs sections and not much more reason to check out the albums section. So an option to disable those from appearing on the bottom bar would make things cleaner (whilst still allowing those who do want those to still have them.)

Also you could add an explore section like Malopied has done with their forked version of the application if only having two tabs feels too empty. Screenshot_20240904-161848.png

hi, @ThatOneUnoriginal! the feature to disable tabs is already available in settings, go check out for it

ThatOneUnoriginal commented 2 weeks ago

hi, @ThatOneUnoriginal! the feature to disable tabs is already available in settings, go check out for it

Oops, I haven't used this version of InnerTune in a while so I have forgotten how a few things work around here. Though noting that you could do that, maybe a setting could be added to allow people to switch between an all-in-one library tab or the current setup (depending on how easy it would be to maintain something like that.)

pdimu commented 2 weeks ago

maybe a setting could be added to allow people to switch between an all-in-one library tab or the current setup

that would be great! what does @z-huang say?