Disable linter checks which cause issues with Weblate formatting

z-huang / InnerTune

A Material 3 YouTube Music client for Android

GNU General Public License v3.0

4.25k stars 265 forks source link

Disable linter checks which cause issues with Weblate formatting #1592

Open lucasmz-dev opened 2 weeks ago

lucasmz-dev commented 2 weeks ago

Disables MissingQuantity and ImpliedQuantity.

Fixes #1591

lucasmz-dev commented 2 weeks ago

~~TODO: Review https://github.com/lucasmz-dev/CONTRIB-InnerTune/pull/1/files?diff=unified&w=0 to check what Weblate is doing when rewriting all translations to try and match a format~~

Seems like what weblate is doing is:

Getting rid of empty lines (not necessarily good but whatever, it makes comparing files with the base file more annoying)
Getting rid of duplicate plurals which are gonna be used anyway (example)
Formatting some multi-line strings (example)

Two things stand out though:

For Belarusian, it believes other should be the same as many, while the original strings were translated to use the same as few. (example)
For French, it gets rid of apostrophes, not sure if the format was just wrong in the first place or what happened (example)

Other than those two issues it seems fine. I tried looking for the Belarusian translator but he seems to have gone EOL.

lucasmz-dev commented 2 weeks ago

I also noticed some of the translation files contained ignore flags for linting from the mentioned issues, these were not removed by Weblate; not sure if we should; probably not

There was one instance that was from ImpliedQuantity, really the one string that caused a warning, seems like it was because it was on only that specific string and Weblate wrote over it.

lucasmz-dev commented 2 weeks ago

I am not sure if this is the right thing to do, that's more on z-huang to decide. It seems it was being done, just on a smaller scale specific to translation, this doesn't seem to be easily possible with Weblate or at least would be an annoying regular job

lucasmz-dev commented 2 weeks ago

For French, it gets rid of apostrophes, not sure if the format was just wrong in the first place or what happened (example)

This is not for all strings, just a few, that for some reason, Weblate just ignores them. This issue doesn't seem to exist in Android, just there. https://translate.codeberg.org/translate/innertune_testing/app/fr/?checksum=8aaaf36a36a9c864&q=dattente&sort_by=-priority%2Cposition#history

lucasmz-dev commented 2 weeks ago

I went over and fixed these manually in Weblate. (The French strings) It actually seems like they were using the wrong symbol for the apostrophes, ` instead of '

Now the only issue left is Belarusian, ~~I think~~ I'm gonna just mark plurals as need for editing and move on.