Closed gechoto closed 3 weeks ago
This does not seem to work anymore since you switched to the IOS client: https://github.com/z-huang/InnerTune/commit/dc6bfce4b70547e8205f84fb2c6963f8acf232b7
Now I have to find out how this is done on IOS but I don't have an IOS device for testing. Can someone with an IOS device help out?
Just saw that ViTune also added this contentCheckOk
:
https://github.com/25huizengek1/ViTune/commit/504b6f717b6b3bef8e71e7ff976a0a2fed4c4e0d
but in ViTune it is a String
instead of a Boolean
. I'm not sure why. I can't test if it makes a difference currently since this confirmation seems to have a cooldown (currently I can play age restricted songs without confirming).
@25huizengek1 what is the reason you made this contentCheckOk
field a string instead of a boolean?
@gechoto I actually can't recall, it was a really rushed debugging session in order to fix streaming for ViTune. During testing it didn't seem to matter though.
@25huizengek1 how did you find all the values needed for the IOS client? Do you have a real IOS device for testing?
@z-huang I currently can't get age restricted songs to work with the IOS client. Would it be okay as a quick fix to re-add the ANDROID_MUSIC
client?
We could maybe do something like this:
ANDROID_MUSIC
client and use IOS
only as fallbackIOS
clientIt's okay. You can add it in this PR.
Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.
Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard. Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
@z-huang done. I suggest to squash the commits on merge.
@gechoto Since I don't own any Apple devices, I just tried different combinations of versions (or user agents) I found in the community: for example yt-dlp, https://github.com/zerodytrash/YouTube-Internal-Clients, NewPipeExtractor, etc.
The rest of the values I got myself by just guessing from the traffic on desktop and Android.
Before:
After:
This implements what the desktop/web player does when you click the button to confirm your age.
I guess you still need to be logged in for this to work. I haven't tested without login but it works with my account.
Maybe fixes https://github.com/z-huang/InnerTune/issues/1442