z-huang / InnerTune

A Material 3 YouTube Music client for Android
GNU General Public License v3.0
4.69k stars 289 forks source link

Release 0.4.4 #469

Closed JPGuillemin closed 1 year ago

JPGuillemin commented 1 year ago

Checklist

Feature description

Please release a stable 0.4.9 for current 0.4.x Master, which is .... Stable :)

Why do you want this feature?

No stable release with latest improvements

Additional information

No response

owencz1998 commented 1 year ago

He's busy working on 0.5.0 with a massive amount of work can't wait to test it out once he's added a debug version for us to try 😀

z-huang commented 1 year ago

It's okay to release a new version with bug fixes and translation update, but I won't include "login to YouTube" feature. The feature is not complete yet.

airon90 commented 1 year ago

@z-huang are there new keys since last release? I don't have time to check sorry

z-huang commented 1 year ago

It seems not.

JPGuillemin commented 1 year ago

Too bad if you would not include the YT login in the release, cause even if it's not complete : it's very stable and actual features seem enough (for me at least)

airon90 commented 1 year ago

@JPGuillemin:

  1. It is not a shame he doesn't add that feature in the next release, at least it is a pity. Be respectful: we all are volunteer
  2. Adding a feature not fully stable is not useful to people. It may be useful for pro users but not for basic ones and it could create many problems
  3. Don't add useless comments. If he doesn't do anything it seems that he is busy (I may be wrong but he studies yet). Please wait and be pacient

Thank you

z-huang commented 1 year ago

Sorry for the late reply. I'm busy preparing the final exam.😅 Please be patient. I'll do that after I'm free. As for the login feature, the biggest change is that your home tab becomes more personalized, but that is not intended (#88). Also, as stated in #456, I want to redesign the home tab. I'm concerned that people would ask for the "unintended feature" when I change the home tab content. Beside that, there's almost nothing different when you're logged in. After all, the most important feature of login - view/sync your online playlists/likes - isn't implemented. Therefore, I think I'll hide the login button in 0.4.4.

JPGuillemin commented 1 year ago

Yes, keep the personalized home tab. Imho it's what makes the yt login worth it.

JPGuillemin commented 1 year ago

@JPGuillemin:

1. It is not a shame he doesn't add that feature in the next release, at least it is a pity. Be respectful: we all are volunteer

2. Adding a feature not fully stable is not useful to people. It may be useful for pro users but not for basic ones and it could create many problems

3. Don't add useless comments. If he doesn't do anything it seems that he is busy (I may be wrong but he studies yet). Please wait and be pacient

Thank you

"a shame" or "a pity" : mean roughly the same in english : playing on words like this is childish.

I'm myself an open-source developer since 1999 (Linux distribution main dev, between many other projects as leader or contributor) please don't try to teach me how I should submit a feature request : I have handled some thousands.

Anyway : I should have written : "Too bad" : it's fixed.