search

z-korp / zkube

Dojo game - Tetris like
https://zkube.vercel.app
MIT License
4 stars 15 forks source link

Contrat new line #11

Closed Cheelax closed 2 months ago

Cheelax commented 3 months ago

Summary by CodeRabbit

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zkube ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2024 1:36pm
coderabbitai[bot] commented 3 months ago

[!WARNING]

Rate limit exceeded

@ClanCo has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 10 minutes and 47 seconds before requesting another review.

How to resolve this issue? After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.
Commits Files that changed from the base of the PR and between 28b9595ada3c1e72bdd6a1f1899182614a8df1cb and 5a1225da20d827676ecf37e8eb87551980e613cd.

Walkthrough

The recent changes introduce a new feature for inserting lines in a game context, significantly enhancing the functionality and organization of the codebase. New interfaces and asynchronous functions improve type safety and modularity, allowing for better management of game states and actions. Additionally, robust testing strategies ensure that all functionalities work as intended, contributing to the maintainability and clarity of the project.

Changes

File Path Summary
client/src/dojo/generated/contractSystems.ts, client/src/dojo/systems.ts Introduced a new interface NewLine and an async function insert_new_line for managing new line operations.
client/src/ui/components/GameBoard.tsx Added insert_new_line functionality to the game board, including state management for insertion.
contracts/manifests/dev/abis/base/contracts/zkube_systems_actions_actions.json, contracts/manifests/dev/abis/deployments/contracts/zkube_systems_actions_actions.json Implemented the insert_new_line function in the ABI for smart contracts, allowing interaction with IWorldDispatcher.
contracts/manifests/dev/base/contracts/zkube_systems_actions_actions.toml, contracts/manifests/dev/manifest.json, contracts/manifests/dev/manifest.toml Updated class_hash and original_class_hash values, indicating changes in contract deployment or logic.
contracts/src/components/playable.cairo, contracts/src/models/game.cairo, contracts/src/systems/actions.cairo Added insert_new_line function to manage game states, enhancing game logic and interactions.
contracts/src/tests/test_move.cairo Introduced test_actions_move_03 to verify the new line insertion logic in game movement tests.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant GameBoard
    participant Contract
    participant DataStore

    User->>GameBoard: Request to insert new line
    GameBoard->>Contract: Call insert_new_line
    Contract->>DataStore: Update game state
    DataStore-->>Contract: Confirmation
    Contract-->>GameBoard: Success response
    GameBoard-->>User: New line inserted

🐇 In the land of code, where rabbits hop,
New lines are added, and we just can't stop!
With functions so fine, and tests all in line,
Our game now dances, oh how it will shine!
Let's celebrate changes, big and small,
For in this great coding, we treasure them all!
🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
Matth26 commented 2 months ago

Cherry picked to dev only the contract side