search

z-korp / zkube

Dojo game - Tetris like
https://zkube.vercel.app
MIT License
4 stars 14 forks source link

Updated leaderboard #29

Closed josephchimebuka closed 2 weeks ago

josephchimebuka commented 3 weeks ago

Fix #18 Key changes:

  1. Updated Game interface to include a default buyIn property
  2. Modified Content component to calculate total buy-in and winning pool
  3. Implemented logic to distribute potential winnings for all
  4. Updated Leaderboard Table with new columns for "Buy-In" and "Potential Winnings"
  5. Modified Row component to display buy-in and potential winnings for each player
  6. Added explanatory tooltips for the new features Screenshot from 2024-08-26 18-37-05

Screenshot from 2024-08-26 19-01-13

Summary by CodeRabbit

Summary by CodeRabbit

vercel[bot] commented 3 weeks ago

@josephchimebuka is attempting to deploy a commit to the z-korp Team on Vercel.

A member of the Team first needs to authorize it.

coderabbitai[bot] commented 3 weeks ago

Walkthrough

The recent changes enhance the leaderboard component to display potential winnings and buy-in amounts for players. Key modifications include updates to the Game interface, new calculation logic for winnings, and UI adjustments for clarity and responsiveness. Additional scripts and dependencies have been introduced to bolster the development environment and testing capabilities.

Changes

File Change Summary
client/package.json Added a new script for testing with Jest and included new dependencies such as @emotion/react, @mui/material, and others for UI and testing enhancements.
client/src/App.tsx Introduced TooltipProvider to enhance tooltip functionality across the application.
client/src/dojo/game/models/game.ts Added a buyIn property to the Game class, initialized to 100.
client/src/ui/modules/Leaderboard.tsx Implemented calculations for potential winnings and updated the UI to display buy-in amounts and winnings; modified Content and Row components accordingly.
client/src/ui/elements/dialog.tsx Adjusted className attributes for improved layout in the DialogContent component.
client/src/hooks/useGames.tsx Minor formatting changes, no functional impact.
client/src/ui/components/GameBoard.tsx Minor formatting changes, no functional impact.
client/src/ui/elements/table.tsx Minor formatting changes, no functional impact.
client/src/ui/elements/tooltip.tsx Minor formatting changes, no functional impact.
client/src/ui/screens/Home.tsx Minor formatting changes, no functional impact.

Assessment against linked issues

Objective Addressed Explanation
Update Game Interface (extend with buyIn, create ExtendedGame interface) ✅
Modify Content Component (calculate total buy-in and winning pool, distribute potential winnings) ✅
Update Leaderboard Table (add columns for "Buy-In" and "Potential Winnings") ✅
Modify Row Component (display buy-in and potential winnings) ✅
Add Explanatory Information (tooltips for potential winnings calculation) ✅

Poem

🐇 In the meadow where numbers play,
A leaderboard shines bright today!
With buy-ins and winnings to explore,
Players hop and cheer for more!
Tooltips whisper secrets fair,
As rabbits dance without a care! 🎉

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
Cheelax commented 3 weeks ago

Hello @josephchimebuka thank you for your work! Can you address the comments sent by rabbit and fix the conflict please?

Cheelax commented 3 weeks ago

& can we remove the buy in column in the leaderboard plz?

josephchimebuka commented 2 weeks ago

Hello @josephchimebuka thank you for your work! Can you address the comments sent by rabbit and fix the conflict please?

Hello @Cheelax I have removed the buy in column in the Leaderboard and I fixed the bugs and updated the PR ser