search

z-korp / zkube

Dojo game - Tetris like
https://zkube.vercel.app
MIT License
4 stars 14 forks source link

feat: content tabs #32

Closed Oshioke-Salaki closed 1 week ago

Oshioke-Salaki commented 2 weeks ago

fixes #24 Feat: Content Tabs

Summary by CodeRabbit

vercel[bot] commented 2 weeks ago

@Oshioke-Salaki is attempting to deploy a commit to the z-korp Team on Vercel.

A member of the Team first needs to authorize it.

coderabbitai[bot] commented 2 weeks ago

[!WARNING]

Rate limit exceeded

@Oshioke-Salaki has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 3 minutes and 19 seconds before requesting another review.

How to resolve this issue? After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.
Commits Files that changed from the base of the PR and between b608896692f385d14bd900ce0ddc3dc47530cd38 and c062e96dd7072b78f631ecc3393e23da8f13b6f9.

Walkthrough

The changes introduce a new ContentTabs component to the React application, featuring three tabs: "Weekly Quests," "News," and "Chests." The component utilizes the shadcn-ui library for enhanced UI capabilities and is styled with Tailwind CSS for a responsive design. Additionally, new components such as ChestCard, NewsCard, and QuestCard have been created to display relevant content within each tab, improving content organization and user experience.

Changes

File Change Summary
client/package.json Added dependency "shadcn-ui": "^0.8.0" for UI enhancements; reformatted existing dependency.
client/src/ui/components/ContentTabs.tsx Created ContentTabs component with tabs for "Weekly Quests," "News," and "Chests," utilizing state management and Radix UI's Tabs.
client/src/ui/components/ChestCard.tsx, client/src/ui/components/NewsCard.tsx, client/src/ui/components/QuestCard.tsx Introduced ChestCard, NewsCard, and QuestCard components for displaying respective content types.
client/src/ui/components/Chests.tsx, client/src/ui/components/News.tsx, client/src/ui/components/WeeklyQuests.tsx Created components to render collections of ChestCard, NewsCard, and QuestCard respectively.

Assessment against linked issues

Objective Addressed Explanation
Create a new ContentTabs component (24) ✅
Implement a tabbed interface within the component (24) ✅
Display current weekly quests in the respective tab (24) ✅
Create sections for news and chests in respective tabs (24) ✅
Write unit tests for the ContentTabs component (24) ❌ Unit tests for the component were not included.

Poem

In a world of quests and news so bright,
Tabs hop along, a joyful sight.
Chests filled with treasures, quests to explore,
With shadcn's magic, we open the door!
A rabbit's delight, so nimble and spry,
Hopping through content, oh me, oh my! 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
Cheelax commented 2 weeks ago

hi @Oshioke-Salaki Some little points:

Oshioke-Salaki commented 2 weeks ago

hi @Oshioke-Salaki Some little points:

  • I see there is a conflict to solve
  • can you send a screen of the component where it's supposed to be?

Done I just places it in the home screen for now. So you can review it

Cheelax commented 2 weeks ago

hi @Oshioke-Salaki Some little points:

  • I see there is a conflict to solve
  • can you send a screen of the component where it's supposed to be?

Done I just places it in the home screen for now. So you can review it

Can you send some screenshots here?

Oshioke-Salaki commented 2 weeks ago
Screenshot 2024-08-29 at 14 35 42 Screenshot 2024-08-29 at 14 35 51 Screenshot 2024-08-29 at 14 36 00
Cheelax commented 2 weeks ago

Thank you. For what I see, we miss the logic of showing and hidding this component right?

Oshioke-Salaki commented 2 weeks ago

Yes we are. So I just passed dummy data as props for now.

Cheelax commented 2 weeks ago

This PR can be merged only if we manage when to view and not to view the modal

Oshioke-Salaki commented 2 weeks ago

Okay should I create a button in the home page to control it? Will that be enough to merge?

Cheelax commented 2 weeks ago

Maybe a button in the header is enough. We need to be able to close it too