z-shell / F-Sy-H

⚙️ Feature-rich Syntax Highlighting for Zsh
https://wiki.zshell.dev/search?q=F-Sy-H
BSD 3-Clause "New" or "Revised" License
165 stars 24 forks source link

fix: move `chroma` into `functions` #42

Open amezin opened 5 months ago

amezin commented 5 months ago

Pull request template

Type of changes

Issue Number: #41

What is the current behavior?

Command-specific highlighting does not work.

$ chroma/-git.ch
zsh: chroma/-git.ch: function definition file not found

What is the new behavior?

Command-specific highlighting works, chroma/*.ch load successfully.

Does this introduce a breaking change?

Other information

N/A

ss-o commented 5 months ago

Hi @amezin :wave:

Could you provide instructions on how to reproduce your issue?

amezin commented 5 months ago

Just use the plugin without any package/plugin manager. https://github.com/z-shell/F-Sy-H/blob/main/docs/README.md#manual

Git subcommands (i.e. "checkout" in "git checkout") won't be highlighted. Zsh will fail to load any chroma/*.ch. Because only functions directory will be added to fpath, not the root directory.

setpill commented 1 month ago

Also experiencing this bug when loading F-Sy-H via zplug. Can confirm that switching to amezin/F-Sy-H@fix/chroma solves it.