z0al / commitlint-bot

[NOT MAINTAINED] use https://github.com/apps/semantic-pull-requests
MIT License
151 stars 24 forks source link

Show a proper error in a commit message with a colon #11

Closed ajsb85 closed 6 years ago

ajsb85 commented 6 years ago

Hi, @ahmed-taj

Take a look in this error msg.

image

image

Reference: https://github.com/flyve-mdm/glpi-plugin/pull/386

ajsb85 commented 6 years ago

Hi, @ahmed-taj We fix the the commit message but... Multiples messages from the bot: https://github.com/flyve-mdm/glpi-plugin/pull/386#issuecomment-378869416

z0al commented 6 years ago

Hey @ajsb85 sorry about that :/

I will try track this down and see what I can do. Also, it might be related to commitlint library itself @marionebl ?

Multiples messages from the bot

The bot posts a single comment for every check. That isn't perfect of course but was initially a workaround not having a server side storage mechanism for reports.

I think I should change the app to modify existing comment instead of creating new one.

ajsb85 commented 6 years ago

Hi, @btry

Could you validate if this CLI Tool show the same issue? https://github.com/marionebl/commitlint

suriyaa commented 6 years ago

@ahmed-taj Same error at https://github.com/SuriyaaKudoIsc/awesome-mozilla/pull/4.

Error notification and status was trigged by @commitlint bot because I used emojis in the commit message.

z0al commented 6 years ago

This should be fixed by #12 . Please feel free to reopen if it's there