z0al / probot-review-me

Decide when a pull request is ready for review based on its statuses
MIT License
16 stars 0 forks source link

Support more labels with different statuses #1

Open johlju opened 6 years ago

johlju commented 6 years ago

When evaluating this app it seemed it can only handle one label when status is in one state. Would be great if this could handle more labels when status are in different states (for example first match will be used).

z0al commented 6 years ago

Hey @johlju, Thanks for giving this app a try 👍

Would you like to elaborate more on this?

johlju commented 6 years ago

I thought of something like this. Apologize if this is not correct YAML, but hopefully you get an idea of what I mean.

First hit in the order written in yml will be true.

# List of contexts (i.e. apps) and their corresponding statuses
# Allowed statuses are:
#
#   - success
#   - failure
#   - pending
#   - error

- when:
    # Using 'detectMergeConflicts: no' should be equal to leave it out entirely.
    detectMergeConflicts: no
    statuses:
      cla-bot: failure

    label: waiting for CLA pass

    # Optional comment written when setting the label
    commentWhenSettingLabel: >
      Waiting for...
      When signed the..

    # Optional, removes all of these labels when setting 'label:'.
    removeLabels:
      - needs review
      - waiting for code fix

- when:
    detectMergeConflicts: yes
    statuses:
      continuous-integration/travis-ci/pr: failure
      cla-bot: success
      wip: success

    label: waiting for code fix

    commentWhenSettingLabel: >
      CI pipeline failed...

    removeLabels:
      - needs review
      - waiting for CLA pass

- when:
    detectMergeConflicts: yes
    statuses:
      continuous-integration/travis-ci/pr: success
      cla-bot: success
      wip: success

    label: needs review

    removeLabels:
      - waiting for code fix
      - waiting for CLA pass
z0al commented 6 years ago

Sorry, for not being responsive lately but I had no PC to work with. But now I can work on those issues ASAP

johlju commented 6 years ago

@z0al That would be cool! Thank you!