WIP: App v2

[z0al]

• [x] Support removing labels ( fixes #2 and related to #4 )
• [ ] Merge conflicts aware ( fixes #3 )
• [x] Support multiple rules ( fixes #1)
• [x] Only check related PR ( fixes #4 )

This is a work in progress. Feel free to review, comment or discuss anything here.

/cc @johlju

[z0al]

Correct me if I'm wrong, I think by adding support for removing labels it should resolve #4, right?

[johlju]

I will look at it and see. I’m not by a computer right now. If I can’t look at it this weekend, I will look at it on Monday! :)

[z0al]

Btw, I checked the "Merge conflicts aware #3 " section by mistake. I've not done something regarding that yet.

Well, I doesn't feel right to add "conflict" as status true/false just like other apps status. Do you have any thoughts regarding that?

[johlju]

@z0al Sorry been extremely busy so haven't had time to get back to this. :/ It still is on my list.

[z0al]

No worries :)

I'm also busy these days but will complete the rest next weekend ISA

[z0al]

I'm back :)

[johlju]

Correct me if I'm wrong, I think by adding support for removing labels it should resolve #4, right?

I don't think it will. See my new comment https://github.com/z0al/probot-review-me/issues/4#issuecomment-417237137.

Well, I doesn't feel right to add "conflict" as status true/false just like other apps status. Do you have any thoughts regarding that?

Thoughts on this here: https://github.com/z0al/probot-review-me/issues/3#issuecomment-417238967

[johlju]

I think this so far only closes #2