z0fa / WoWQuestTTS

6 stars 1 forks source link

Narrator #14

Closed BelegCufea closed 2 months ago

BelegCufea commented 2 months ago

Hello there,

I was playing with using the third voice as a narrator that will read quest titles, NPC names, objectives, and anything in < > brackets.

I have cobbled up some changes to the code, including settings, both in Retail and Classic. I've played with it in Retail for a day or so and tried one quest in Classic. It seems to work but may need some more testing.

The new code is run only when Settings.useNarrator is true; otherwise, your original code is run without any changes.

And one more thing—I don’t know if it was intentional, but in immersion.lua, the OnHide hook was calling Main.ttsStop(). I changed it to Main.ttsAutoStop() to be in line with the "vanilla" experience.

As a non-native English speaker, I love your addon. Thank you very much!

Whether you choose to use this Pull Request or not is up to you!

BelegCufea commented 2 months ago

Oops, sorry, will redo the PR :-)