Fix for issue 5 (Shfmt silently eats changes)

alpayne commented 5 years ago

changed call to shfmt to treat it as a filter instead a system call
- process the current buffer instead of the saved file
- write changed to STDOUT and use to replace buffer
trap error if shfmt fails and undo change to prevent leaving the user staring at a blank buffer
added restore of the cursor postion when filter returns (default leaves the user with cursor at top of file)
reverted to using triggering autocmd on BufWritePre because we want filter to run before the file is written
- note: if shfmt exits with an error on save the user isn't notified, but the file is saved as is without changes

andrewimeson commented 5 years ago

Fixes #5

andrewimeson commented 5 years ago

@z0mbix I've tested this branch and it solves my issue.

z0mbix commented 5 years ago

@andrewimeson thanks for reporting this. @alpayne Thanks very much for your contribution, this is great :)

z0mbix / vim-shfmt