search

z0w0 / helm

A functionally reactive game engine, with headgear to protect you from the headache of game development provided.
http://helm-engine.org/
MIT License
598 stars 69 forks source link

Add fps limit game configuration. #120

Closed nikita-leonov closed 6 years ago

nikita-leonov commented 6 years ago

Introduced FPS limit as discussed in #111. This is my first ever non-experimental Haskell contribution, so some things may be non-traditional for regular Haskell developers, so reviews and improvement suggestions are appreciated.

z0w0 commented 6 years ago

Thanks! Looks good to me, however I think the defaultFPSLimit function looks inconsistent with the SDL.defaultConfig. Perhaps GameConfig should be renamed to something else and GameConfig should be config stuff like fpsLimit and updateLimit. But that's a problem for another day.

nikita-leonov commented 6 years ago

Wow, this was fast :) I wish I got more feedback to learn Haskell even more.