search

z1dev / zkanji

Japanese language study suite and dictionary
GNU General Public License v3.0
60 stars 10 forks source link

Different default colors for dark theme #3

Closed z1dev closed 6 years ago

z1dev commented 7 years ago

The default colors (mostly for different texts) were selected with a light theme in mind, but they don't look nice when the theme is dark. I have committed code that will allow a separate default color palette on a dark theme.

The defaults can be found in colorsettings.h in the ColorSettings structure. Defaults for the light theme are stored in const variables with names ending in ldef. The defaults for the dark theme end in ddef. I will get to this in time, but if anyone is willing, you can help finding a nice looking theme. The colors are in almost the same order as they can be found in the settings dialog window. Defaults for the base text colors and backgrounds are not stored in the code, since I get them entirely from the system via QApplication::palette().

z1dev commented 6 years ago

I set some (maybe temporary) colors for dark themes. They are visible so there's no need to keep this issue open.