search

z1dev / zkanji

Japanese language study suite and dictionary
GNU General Public License v3.0
59 stars 10 forks source link

Kanji are too big inside "kanji boxes": handwriting tool and kanji search #30

Open jhack-jos opened 4 years ago

jhack-jos commented 4 years ago

Thank you for the wonderful work creating Zkanji. I was a huge fan of Zkanji since the very start, and it helped me greatly in becoming the Japanese interpreter that I am now.

I'd like to signal a bug with the "kanji boxes" in the handwriting tool and kanji search in the v0.1.0 beta. See the pictures attached to understand the problem. Basically the kanji are too big to fit in their boxes and are hard to read.

Zkanji - handwriting - kanji box bug Zkanji - kanji search - kanji box bug

I apology in advance if the problem was already solved in the commits after the build. Warmest Regards, Jhack

z1dev commented 3 years ago

Hi! Sorry for not writing before, but GitHub forgot to notify me of issues posted here apparently for a while now. I haven't seen multiple issues until now.

I'm not working on this project anymore. I wanted to make a full release and maybe add some small adjustments years ago, but for a long time nobody tested zkanji or reported issues, and I didn't want to make a full release of a possibly buggy program, then I moved on.

I'm using Qt, a library for multi-platform development, which is open source, and is using another open source project for font display. As you can see, it... works... but many fonts have wrong size data, and Qt (and its library) don't try to compensate for this, unlike the old method which is built into Windows itself. I could get around this by testing if the printed font size is wrong, and doing other tricks, but simply using a different font should solve this too. Please try that if you can.

morgenman commented 3 years ago

Hey, I modified a font to fix it: https://drive.google.com/file/d/1ba3JM7CGiApysaGMQEGAmKgq7FLQ0icI/view?usp=sharing