z1dev / zkanji

Japanese language study suite and dictionary
GNU General Public License v3.0
60 stars 10 forks source link

Radical Search bug #36

Closed MarcusAseth closed 3 years ago

MarcusAseth commented 3 years ago

As you can see in the image below, the radical search is bugged, because if I select that many radicals I should get no resoults at all Capture

z1dev commented 3 years ago

This is more of an issue of lack of a manual. I guess an explanation is needed how the radical searches work, because this was changed from old versions.

The "Parts", "Radicals" and "Radicals as Parts" searches work differently. You can select multiple in "Parts" and zkanji will show you every kanji that might have any of the parts. But if you click the "add" button, and continue selecting, now you will only get results from the previously found kanji. On the other hand "Radicals" only has the first step, so all kanji will be shown that have any of what you picked. This is because kanji radical is the one part that dictionaries usually use to index kanji. Each kanji only has one of this. Selecting multiple and filtering those kanji that have every single radical selected at the same time thus makes no sense, because nothing would be shown. "Radicals as parts" works like the "Parts" search, but it gives you the option to select radicals by name. In this case it's not really the radical that will be used to search for kanji, but parts (like in the "parts" search) that look like the radicals.

I hope this clears things up!

MarcusAseth commented 3 years ago

It does! Thanks I wish though that if I were holding Shift while selecting a part, it would pick the part and automatically do an Add, this would effectively make it behave like the old zkanji, thus saving time by not having to select a part then going to click Add - just a QoL thing ^_^' So if you happen to mess with it in the future, that might be a nice addition!

z1dev commented 3 years ago

I should have closed this too since "it's not a bug, it's a feature!" (I'm borrowing MS' slogan!)