z1pti3 / jimi

Jimi is an automation first no-code platform designed and developed originally for Security Orchestration and Response. Since its launch jimi has developed into a fully fledged IT automation platform which effortlessly integrates with your existing tools unlocking the potential for autonomous IT and Security operations.
https://www.secureack.com
Apache License 2.0
159 stars 31 forks source link

[Bug] Cannot rename storage files #271

Closed b1scuit-thi3f closed 2 years ago

b1scuit-thi3f commented 2 years ago

Describe the bug Non admin users cannot rename a storage file once uploaded. They get a 500 Server Error instead.

To Reproduce Login to jimi as a non-admin user who can upload to storage. Upload the file and then try to rename.

Expected behaviour The user should be able to rename the object.

u-n-i-c-o-rn commented 2 years ago

+1 for a quick fix on this I am facing the same issue after I started to rollout to more users

b1scuit-thi3f commented 2 years ago

https://github.com/z1pti3/jimi/blob/59588fbd73821fde2da6ebb7114f2fa485c55c75/core/storage.py#L144-L148

Looks like this might be the issue

I don't think edit is a valid acl type to look for. Should this be write?