z390development / z390

z390 Portable Mainframe Assembler and Emulator Project
GNU General Public License v2.0
39 stars 15 forks source link

Build procedure: generated macros are used before they are generated #556

Closed abekornelis closed 3 months ago

abekornelis commented 3 months ago

the macros generated by the bat\BLDZSTRMAC.BAT or the bash\bldzstrmac procedure are used a.o. in the build of zCobol. They could be used in any assembler program that is part of z390. So the bldzstrmac procedure needs to be the first thing to be run after the jar has been created.

Currently, it is executed as part of the groovy test suite, long after the build procedure has completed.

Since the generated macros are saved in the repository, we never notice. But in fact the z390 builld procedure is consistently using the "prior" version in any build. When making a change to the input files you'd have to run the build/test cycle twice to propagate the changes properly into the compiled code.

The bat and bash scripts need to be changed to run the appropriate bldzstrmac procedure. The groovy script RunZSTRMacTest needs to be removed or replaced such that it becomes part of the build process.

abekornelis commented 3 months ago

Resolved by PR #557