z390development / z390

z390 Portable Mainframe Assembler and Emulator Project
GNU General Public License v2.0
40 stars 15 forks source link

Module tz390.java uses invalid argument for a String compare #564

Closed jyganci closed 2 months ago

jyganci commented 2 months ago

When working on a non-z390 project in Eclipse, noticed warning message "Unlikely argument type for equals(): char seems to be unrelated to String" for z390 module tz390.java. Problem line is

else if (override.substring(0,i).equals(mask_char)) // #495

Should be

else if (override.substring(0,i).equals(String.valueOf(mask_char))) // #495

jyganci commented 2 months ago

Fixed by pull request 565.