z390development / z390

z390 Portable Mainframe Assembler and Emulator Project
GNU General Public License v2.0
39 stars 15 forks source link

Compile java without copying sources around #587

Closed abekornelis closed 1 month ago

abekornelis commented 1 month ago

Mail by John Ganci dd 2024-10-03 18:31

When bash/bldjar was originally written, I questioned why bat/BLDJAR.BAT copied all the java source and the Z390.MAN file to the jar directory. There is a javac option, -d, that specifies the directory to contain the class files. The bash/bldjar script uses that option, which avoids the needless copying of the java source and Z390.MAN. At the time, I chose not to make the corresponding changes to BLDJAR.BAT, thinking Don might've had some reason for doing it the way he did.

Anyway, bash/bldjar works fine. No copying of the java source and Z390.MAN ahead of the compiles.

You might consider changing BLDJAR.BAT to do the same. It is just a small change to the javac and jar commands and simplifying what files are removed from the jar directory before the compiles are done. You'll see what I mean if you look at the two source files side by side.

abekornelis commented 1 month ago

Fixed by PR #588