search

z3z1ma / dbt-osmosis

Provides automated YAML management, a dbt server, streamlit workbench, and git-integrated dbt model output diff tools
https://z3z1ma.github.io/dbt-osmosis/
Apache License 2.0
422 stars 45 forks source link

Introduce `pre-commit` #100

Closed yu-iskw closed 9 months ago

yu-iskw commented 9 months ago

Overview

In my opinion, it would be good to introduce pre-commit to develop dbt-osmosis so that we consistently format files and coding standards a head of pushing the default branch.

We can run the hooks with the subsequent commands. 

pip install -U pre-commit

pre-commit install

pre-commit run --all-files
yu-iskw commented 9 months ago

@z3z1ma Can you review the pull request?

z3z1ma commented 9 months ago

Same as other. Once we rebase and resolve conflicts, I will merge and cut a release. Good call on pre-commit.

yu-iskw commented 9 months ago

I will resolve the conflicts as soon as possible.

yu-iskw commented 9 months ago

@z3z1ma Can you review it again? I have resolved the conflicts. To do so, I had to get poetry.lock updated with poetry lock --no-update. But, I don't think it breaks anything in the existing functions.