search

z3z1ma / dbt-osmosis

Provides automated YAML management, a dbt server, streamlit workbench, and git-integrated dbt model output diff tools
https://z3z1ma.github.io/dbt-osmosis/
Apache License 2.0
422 stars 45 forks source link

Add test for update_undocumented_columns_with_prior_knowledge function #109

Closed syou6162 closed 9 months ago

syou6162 commented 9 months ago

Continued from https://github.com/z3z1ma/dbt-osmosis/pull/96.

The update_undocumented_columns_with_prior_knowledge function has a lot of flags (skip_add_tags / skip_merge_meta / add_progenitor_to_meta) involved. Therefore, it was not clear how they behave. We have added a test to this function to make it easier to follow the behavior.

In adding testing, I also corrected some behavior that differed from the documentation (the documentation says it mutates the NODE, but in fact it does not).

syou6162 commented 9 months ago

@z3z1ma Thank you for reviewing & I fixed conflicted codes! Could you merge this pull request?

z3z1ma commented 9 months ago

lgtm :shipit: