Add more types to improve code readability

z3z1ma / dbt-osmosis

Provides automated YAML management, a dbt server, streamlit workbench, and git-integrated dbt model output diff tools

https://z3z1ma.github.io/dbt-osmosis/

Apache License 2.0

422 stars 45 forks source link

Closed syou6162 closed 8 months ago

syou6162 commented 9 months ago

The following types have been added to improve code readability

Add type for catalog with CatalogArtifact
- The current type definition is Optional[dict], but it is difficult to know what kind of key it has, so we changed it to clearly show CatalogArtifact.
Replace Tuple[str, str, str] with CatalogKey.
- It is hard to remember what is the first in a code like parts[-1], so changed it to be easier to understand with CatalogKey.

z3z1ma commented 8 months ago

LGTM much better