search

z3z1ma / dbt-osmosis

Provides automated YAML management, a dbt server, streamlit workbench, and git-integrated dbt model output diff tools
https://z3z1ma.github.io/dbt-osmosis/
Apache License 2.0
422 stars 46 forks source link

Fix `skip_add_data_types` condition in `update_columns_data_type` #140

Closed syou6162 closed 2 months ago

syou6162 commented 2 months ago

@z3z1ma After updating dbt-osmosis to version 0.12.8, I noticed that the data_type attribute disappears from within the yaml. After reading the source code, I noticed that the skip_add_data_types condition in the update_columns_data_type function is wrong, so I will fix it.

z3z1ma commented 2 months ago

Ah good catch, thanks. 🙇 🙏

syou6162 commented 2 months ago

@z3z1ma Thank you for merging, and I'm waiting for the new version to be released with the fixes reflected!

syou6162 commented 2 months ago

I found https://github.com/z3z1ma/dbt-osmosis/releases/tag/v0.12.9, thank you!