search

z3z1ma / dbt-osmosis

Provides automated YAML management, a dbt server, streamlit workbench, and git-integrated dbt model output diff tools
https://z3z1ma.github.io/dbt-osmosis/
Apache License 2.0
456 stars 46 forks source link

fix: refactor imports for dbt 1.8.0+ #149

Closed ryan-pip closed 4 months ago

ryan-pip commented 4 months ago

Fix import paths for dbt common and adapter components for dbt 1.8.0.

syou6162 commented 4 months ago

@ryan-pip Can you pull the latest from the main branch and add dbt 1.8 to the test?

The reason for this addition is to make sure that this pull request works correctly with dbt 1.8 and that dbt 1.7 and below also work fine. FYI @z3z1ma

ryan-pip commented 4 months ago

Did you want me to add dbt-version 1.8.0 to the versions that will be tested as well?

syou6162 commented 4 months ago

@ryan-pip Yes, I would like you to do so, and to ensure that dbt-osmosis works with multiple dbt-core versions, we would like to add 1.8.0 to our test subject. This would make dbt-osmosis more maintainable.

ryan-pip commented 4 months ago

@syou6162, Tests have been added and are passing. Anything else needed here?

syou6162 commented 4 months ago

@ryan-pip Thanks for adding the test!

@z3z1ma We have confirmed on CI that it works fine with 1.8 and versions prior to 1.7, so it looked good. Could you please review it?

z3z1ma commented 4 months ago

LGTM thanks, I will cut a new release on PyPI and get the changelog, readme, and docs site updated.

FrankTub commented 3 months ago

@z3z1ma , when can we expect a new version?