search

z3z1ma / dbt-osmosis

Provides automated YAML management, a dbt server, streamlit workbench, and git-integrated dbt model output diff tools
https://z3z1ma.github.io/dbt-osmosis/
Apache License 2.0
456 stars 46 forks source link

Modify to support dbt-core 1.6 and above #151

Closed syou6162 closed 4 months ago

syou6162 commented 4 months ago

Currently, dbt-osmosis supports a very wide range of dbt-core versions. As a result, there is code that diverges depending on the version of dbt-core, resulting in complexity and test case omissions. And Support level and end date for dbt 1.5 and below is End of Life.

This pull request explicitly limits the supported dbt-core versions so that dbt-osmosis can keep up with new dbt-core versions as they become available and remain highly maintainable.

syou6162 commented 4 months ago

@z3z1ma As I had received prior feedback in the comments, I have prepared a pull request with a modification to explicitly remove support for versions below 1.5 of dbt-core. Could you review it?

z3z1ma commented 4 months ago

LGTM, thanks so much @syou6162 🙇