search

z3z1ma / dbt-osmosis

Provides automated YAML management, a dbt server, streamlit workbench, and git-integrated dbt model output diff tools
https://z3z1ma.github.io/dbt-osmosis/
Apache License 2.0
483 stars 49 forks source link

Support for Python 3.12 #183

Open temminks opened 3 weeks ago

temminks commented 3 weeks ago

Can we update the pyprojekt.toml file so that dbt-osmosis would run with Python 3.12? I tried setting the allowed python versions to "...<3.13" and was able to poetry install the project.

Are there other requirements that need to be considered before updating?

temminks commented 5 days ago

I think the current design of the test pipeline won't work with the update of the python versions: You are currently installing dbt-core using poetry add which will evaluate the python-versions defined in tool.poetry.dependencies. This is already failing for your current test-matrix for dbt-core 1.6.0 and 1.7.0 (eg, https://github.com/z3z1ma/dbt-osmosis/actions/runs/11859711262/job/33053298311). Only since dbt-core >= 1.7.9 supports python 3.12.

I think a more realistic testing scenario would be to install dbt-core 1.6.0 first and then install dbt-osmosis as a package to be used with that version.

I started a branch here that I'll have to clean up: https://github.com/temminks/dbt-osmosis