Modify existing tests or rewrite new tests

[syou6162]

@z3z1ma As mentioned here, I am considering writing tests for dbt-osmosis. I discovered that there are existing tests (tests), but they did not work on my local environment. For example, due to changes in the internal code of dbt-osmosis, the following code either did not run or the source code where it was defined no longer exists.

• https://github.com/z3z1ma/dbt-osmosis/blob/main/tests/sqlfluff_templater/test_server_v2.py#L6
• https://github.com/z3z1ma/dbt-osmosis/blob/main/tests/sqlfluff_templater/conftest.py#L14-L19

There are several ways to add tests to dbt-osmosis, such as the ones listed below. I would like to hear your thoughts as a repository owner on which plan is best.

• Plan A: Carefully modify the existing tests to make them pass.
  • At first glance, this seems like the right approach, but you also maintain the dbt-core-interface repository.
  • I felt that the content currently covered by the tests in dbt-osmosis seemed to be covered in dbt-core-interface. In fact, I confirmed that there are tests with almost the same content.
  • Question: Do you have any plans to replace the dbt-osmosis code with one using dbt-core-interface in the future?
  • If this assumption is correct, it doesn't seem like a good idea to write the same tests in dbt-osmosis that are in dbt-core-interface.
• Plan B: Delete the existing tests and add new tests for core features of dbt-osmosis, such as column propagation.
  • If possible, I would like to choose this plan.

Please let me know what you think. Based on your feedback, I plan to submit a pull request for the tests.

[z3z1ma]

All /tests in dbt-osmosis can be scratched. dbt-core-interface is vendored inside dbt-osmosis. Which means the tests done upstream are applicable to the approach here. My suggestion would be to scope the tests to just the YAML manipulation, column and metadata propagation, file migrations, or things of that nature. And leave the more low level testing to dbt-core-interface as needed.

Plan B: Delete the existing tests and add new tests for core features of dbt-osmosis, such as column propagation. If possible, I would like to choose this plan.

So this one for sure