search

z411 / trackma

Open multi-site list manager for Unix-like systems. (ex-wMAL)
https://z411.github.io/trackma
GNU General Public License v3.0
775 stars 81 forks source link

fix: scan only currently watching when scan_whole_list is disabled #599

Closed serjflint closed 2 years ago

serjflint commented 2 years ago

Relates: #598

z411 commented 2 years ago

This was the original behavior. This was changed because people wanted also to scan on hold and plan to watch lists as well, as they usually don't have a lot of results in them either.

serjflint commented 2 years ago

@z411 they can use "Scan through whole list" for that, though.

z411 commented 2 years ago

@z411 they can use "Scan through whole list" for that, though.

Scan through whole list also scans through Finished, which is most of the time, a ton. This PR removes a feature that was requested. In that case we could add three options: Scan only watching, scan usual lists (watching, on hold, plan_to_watch), scan everything (edge case, probably).

serjflint commented 2 years ago

@z411 I agree. The option to choose what to scan is better. That's why I called this PR 'a dirty hack' in the discussion =)

FichteFoll commented 2 years ago

Scan only watching, scan usual lists (watching, on hold, plan_to_watch), scan everything (edge case, probably).

Would making the list of statuses to scan configurable be feasible? That would certainly be the most flexible options and I think also be more transparent for the user since the current behavior even confused me in the code (i.e. what do statuses_library, statuses, and statuses_start mean exactly?).

serjflint commented 2 years ago

@FichteFoll better move to the related issue. I closed this PR and we need a new one to solve the issue the way you mentioned.