z411 / trackma

Open multi-site list manager for Unix-like systems. (ex-wMAL)
https://z411.github.io/trackma
GNU General Public License v3.0
761 stars 82 forks source link

Drop Qt4 and support Qt6 #628

Open txtsd opened 1 year ago

txtsd commented 1 year ago

Qt4 has been EOL since 2015.

It's time to drop support in the codebase, turn Qt5 into legacy, and focus on supporting Qt6 instead.

alsoGAMER commented 1 year ago

i was working on this on my fork here, if anyone could contribute that would help speeding up the process

txtsd commented 1 year ago

Oh good. I'll test it later today or tomorrow and see how I can help.

alsoGAMER commented 1 year ago

Oh good. I'll test it later today or tomorrow and see how I can help.

thanks! the state of that fork is mostly working; it starts, renders the lists (though without the colored bars) and images, also updating the lists locally and remotely works fine.

there are still some issues with writing to files (especially the config one), but that is something I'm unable to work out how to fix.

txtsd commented 1 year ago

@alsoGAMER How are you launching it? trackma-qt -6 does not do anything different, and it seems to be using qt5 like normal.

alsoGAMER commented 1 year ago

@txtsd make sure your local clone isn't broken, i made some big changes to the repo some days ago.

also I'm using an archlinux distrobox to run it with qt6 and it works flawlessly, so you can try that.

alsoGAMER commented 1 year ago

@txtsd did you get it working?

txtsd commented 1 year ago

Not yet. I've been battling respiratory illnesses :(

alsoGAMER commented 1 year ago

Not yet. I've been battling respiratory illnesses :(

Oh i see, hope you'll recover soon.

txtsd commented 1 year ago
λ python setup.py develop --prefix=/tmp/trackma
running develop
/usr/lib/python3.10/site-packages/setuptools/command/easy_install.py:144: EasyInstallDeprecationWarning: easy_install command is deprecated. Use build and pip and other standards-based tools.
  warnings.warn(
/usr/lib/python3.10/site-packages/setuptools/command/install.py:34: SetuptoolsDeprecationWarning: setup.py install is deprecated. Use build and pip and other standards-based tools.
  warnings.warn(
Checking .pth file support in /tmp/trackma/lib/python3.10/site-packages
/usr/bin/python -E -c pass
TEST FAILED: /tmp/trackma/lib/python3.10/site-packages does NOT support .pth files
bad install directory or PYTHONPATH

You are attempting to install a package to a directory that is not
on PYTHONPATH and which Python does not read ".pth" files from.  The
installation directory you specified (via --install-dir, --prefix, or
the distutils default setting) was:

    /tmp/trackma/lib/python3.10/site-packages

and your PYTHONPATH environment variable currently contains:

    ''

Here are some of your options for correcting the problem:

* You can choose a different installation directory, i.e., one that is
  on PYTHONPATH or supports .pth files

* You can add the installation directory to the PYTHONPATH environment
  variable.  (It must then also be on PYTHONPATH whenever you run
  Python and want to use the package(s) you are installing.)

* You can set up the installation directory to support ".pth" files by
  using one of the approaches described here:

  https://setuptools.pypa.io/en/latest/deprecated/easy_install.html#custom-installation-locations

Please make the appropriate changes for your system and try again.
running egg_info
writing Trackma.egg-info/PKG-INFO
writing dependency_links to Trackma.egg-info/dependency_links.txt
writing entry points to Trackma.egg-info/entry_points.txt
writing requirements to Trackma.egg-info/requires.txt
writing top-level names to Trackma.egg-info/top_level.txt
adding license file 'COPYING'
adding license file 'AUTHORS'
writing manifest file 'Trackma.egg-info/SOURCES.txt'
running build_ext
Creating /tmp/trackma/lib/python3.10/site-packages/Trackma.egg-link (link to .)
Installing trackma script to /tmp/trackma/bin
Installing trackma-curses script to /tmp/trackma/bin
Installing trackma-gtk script to /tmp/trackma/bin
Installing trackma-qt script to /tmp/trackma/bin
Installing trackma-qt4 script to /tmp/trackma/bin

Installed /home/txtsd/git/trackma
Processing dependencies for Trackma==0.8.5
Finished processing dependencies for Trackma==0.8.5
λ /tmp/trackma/bin/trackma-qt -d -h
Trackma-qt v0.8.5
Usage: trackma-qt [options]

Options:
 -d  Shows debugging information
 -4  Force Qt4
 -h  Shows this help

It doesn't show or recognize the -6 flag. Your qt6-rework branch is checked out.

alsoGAMER commented 1 year ago

I don't know why is behaving that way, i just retried the setup from scratch and worked perfectly fine.

image image

v-fox commented 3 months ago

Rebased @alsoGAMER's patch to get rid of PyQt5 from the system: trackma_qt6-rework.zip For some reason github craps itself on unzipped patch-file.