z411 / trackma

Open multi-site list manager for Unix-like systems. (ex-wMAL)
https://z411.github.io/trackma
GNU General Public License v3.0
761 stars 82 forks source link

App icon breaks under Wayland [Kde] #638

Closed alsoGAMER closed 1 year ago

alsoGAMER commented 1 year ago

Steps to reproduce:

Reported behaviour:

Screenshots and app version: window taskbar

Package trackma-git built on chaotic-aur Version 0.8.4.r191.g0a2558e-1

FichteFoll commented 1 year ago

Does this also occur with the GTK UI?

alsoGAMER commented 1 year ago

Does this also occur with the GTK UI?

Sadly I can't test that, cause that version crashes instantly every time that I try to open it.

FichteFoll commented 1 year ago

Please open it from the terminal via trackma-gtk -d and post the output. That definitely shouldn't happen.

alsoGAMER commented 1 year ago

Please open it from the terminal via trackma-gtk -d and post the output. That definitely shouldn't happen.

Doesn't happen anymore, I guess it was caused by some broken system update, that now fixed itself. The icon works for the GTK variant though.

z411 commented 1 year ago

Maybe a bug fixed in Qt6? Seems doubtful though. I remember using the standard Qt way to set the application icon, but I have no way to test under Wayland (thanks NVIDIA)...

alsoGAMER commented 1 year ago

I could test if you want to (and if you have any qt6 variant already done).

KodyVB commented 1 year ago

654 Fixed it for the panel's icons-only task manager for me, but unfortunately I don't know how to fix the icon in the title bar. A couple applications I wrote in PyQt had both broken as well, and the same solution fixed both locations for those applications, but for some reason it's not fixing it in the title bar for Trackma. I'd like to fix the problem fully, but my Google-fu doesn't seem to be advanced enough to do so.

Edit: I eventually found a way to get it fixed in both locations with Trackma.

txtsd commented 1 year ago

The icon has been working fine for me on Sway on Arch.

KodyVB commented 1 year ago

@txtsd I've been experiencing the issues on KDE's Wayland, as with the original issue. Would you be up for testing whether or not changing app.setDesktopFileName("trackma") to app.setDesktopFileName("trackma-qt") in line 76 of trackma/ui/qt/__init__.py breaks the icon for you as a Sway user?

txtsd commented 1 year ago

~~Hold up. I was looking in the tray, where the icon is correct. The app icon in the taskbar, however, is neither correct in 0.8.5, nor in #654 with the change you mentioned.~~ EDIT: Wrong yet again. My theme just has a strange icon for trackma which I saw in the taskbar. My tray icon is the MAL icon. It has indeed been working fine, and changing setDesktopFileName doesn't change the behavior.

alsoGAMER commented 1 year ago

fixed via 7d69f70