z411 / trackma

Open multi-site list manager for Unix-like systems. (ex-wMAL)
https://z411.github.io/trackma
GNU General Public License v3.0
761 stars 82 forks source link

Set desktop file name for Wayland icon #654

Closed KodyVB closed 1 year ago

KodyVB commented 1 year ago

I found this solution to Wayland not showing the icon for PyQt applications thanks to the KDE guidelines here.

I was having the same issue of the Wayland yellow and white icon showing in the application's title bar and in the task manager on the panel with some PyQt6 applications I made. When I added this line, it fixed the icon issue for both locations with my applications, but for some reason it's not fixing it for Trackma's title bar icon. Still, I figured this was better than nothing, as it fixes it for the task manager on the panel.

Edit: I hadn't realized setDesktopFileName was already called in __init__.py. The second commit uses that original call instead of calling the function again. Still having the same problem of it not fixing the title bar in KDE Wayland, though.

KodyVB commented 1 year ago

Okay, making the "T" in trackma-qt lowercase made it work in both locations. I don't know why I didn't think of trying this earlier. I honestly feel a bit silly about it and wish I would have thought about it before that first or second commit, lol. This seems to be working just fine for me on KDE's Wayland.

alsoGAMER commented 1 year ago

Can confirm this fixes the issue