search

z4kn4fein / stashbox

A lightweight, fast, and portable dependency injection framework for .NET-based solutions.
https://z4kn4fein.github.io/stashbox
MIT License
140 stars 10 forks source link

Some warnings about missing constructors for Exceptions #117

Closed schuettecarsten closed 2 years ago

schuettecarsten commented 2 years ago

When you compile Stashbox on your own, it shows a lot of warnings about missing constructors for several Exception types.

warning CA1032: Add the following constructor to CircularDependencyException: public CircularDependencyException()
warning CA1032: Add the following constructor to CircularDependencyException: public CircularDependencyException(string message)
warning CA1032: Add the following constructor to CircularDependencyException: public CircularDependencyException(string message, Exception innerException)

These warnings are shown for:

CircularDependencyException
CompositionRootNotFoundException
ConstructorNotFoundException
LifetimeValidationFailedException
ResolutionFailedException
ServiceAlreadyRegisteredException
InvalidRegistrationException

Please either implement these constructors or suppress the warning.

Quality rule: https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1032

z4kn4fein commented 2 years ago

Hi, Thanks for the report, I'll look at it!

z4kn4fein commented 2 years ago

I have pushed the suppression for that warnings to master, could you please check? Thanks!

github-actions[bot] commented 2 years ago

This issue is marked stale because it has been open for 90 days with no activity.

github-actions[bot] commented 2 years ago

This issue was closed due to no activity.