Fix attachment request if content type is application/octet-stream

z4r / python-rtkit

Python Api for Request Tracker's REST interface

http://z4r.github.com/python-rtkit/

Other

68 stars 44 forks source link

Fix attachment request if content type is application/octet-stream #49

Closed sim0nx closed 7 years ago

sim0nx commented 7 years ago

When fetching binary attachments from RT with a returned content-type of application/octet-stream; trying to decode the body as utf-8 does not work and throws an exception.

The following is a simple fix to just ignore any decoding issues and fixes the issue.

Any chance you could merge this please?

z4r commented 7 years ago

Hi @sim0nx, thx for your commit.

Of course the issue on travis is not your fault.

Could you pls remove all occurrences of --use-mirrors in the .travis.yml and push again on this PR?

sim0nx commented 7 years ago

Hi, Sure, done :-)

Hmm it still fails with the same error, looks like travis does not take the latest commit into account...hmm

sim0nx commented 7 years ago

I opened a new PR #50 to try to fix the travis run problem