search

z80playground / cpm-fat

CP/M for the Z80 Playground that runs on the FAT disk format
GNU General Public License v3.0
20 stars 9 forks source link

Are you open to pull-requests? #37

Closed skx closed 3 years ago

skx commented 3 years ago

I've just submitted an order for the hardware and now I'm looking over the code.

Off the top of my head there are a couple of simple changes/contributions I'd suggest making:

Are you open to pull-requests? Or do you even have ideas of things that you'd like to see but don't have time.

(On the topic of messages I wrote some code to print "inline" strings here - string-output.z80, that could could almost be dropped inline, I'd just wrap the entry with push af, and exx to preserve the registers. Without the hardware I can't test, but I think that should preserve everything neatly and avoid the stack-juggling you've come up with :)

z80playground commented 3 years ago

Thanks Steve. I've been really busy recently and I am only just starting to get back on top of this project. I totally agree about the symbol files. I never use them. A Makefile is a good idea. I use VSCODE and have it all on a hot-key, but I see what you mean. Yes, message.asm is a bit of a mess!