z88dk / z88dk

The development kit for over a hundred z80 family machines - c compiler, assembler, linker, libraries.
https://www.z88dk.org
Other
913 stars 173 forks source link

Are the rcmx_cpi & friends needed in the library? #359

Closed pauloscustodio closed 7 years ago

pauloscustodio commented 7 years ago

z80asm now includes the emulation libraries for CPI, CPIR, CPD and CPDR at the link phase if assembling for a Rabbit.

The source of these libraries is in src/z80asm/dev/z80asm_lib and they are deployed to the lib/ directory during install

I've found and fixed a bug in the output of the H and N flags in the CPIR and CPDR routines in commit c2bcbbfe389cca9c3d89d9605cf1bcb06c9c4756

Should I update the copies in libsrc/z80_crt0s/z80_emu, or remove them and keep them only in the z80asm source tree?

aralbrec commented 7 years ago

z80asm will link these replacements last so it will be possible for the user or library to override them?

suborb commented 7 years ago

I think I adjusted all references to them to the z80asm version, but forgot to remove the rcmx versions. So they can go.

pauloscustodio commented 7 years ago

Yes, z80asm will search the z80asm-{cpu}-{ixiy}.lib last, allowing the user to override the z80asmxxx functions.