zBlock-2 / summa-solvency-diffie

Apache License 2.0
0 stars 0 forks source link

Magic numbers used in code of MST Circuit to create PoseidonChip #15

Open bbresearcher opened 7 months ago

bbresearcher commented 7 months ago

Describe the bug There are hardcoded integers used in the construction of the Poseidon chips

Expected behavior Either create named constants or document the values used in a comment

Additional context https://github.com/summa-dev/summa-solvency/blob/master/zk_prover/src/circuits/merkle_sum_tree.rs#L237-L245