search

zD12 / galaxium

Automatically exported from code.google.com/p/galaxium
0 stars 0 forks source link

Issue with links in chat window #249

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
write "(http://localhost/)?" to someone.

part after / should be in href="", but here ")?" is part of link.

probably Konnekt (http://konnekt.info/) messenger had a regex link matching
in history search.

Original issue reported on code.google.com by jakub.ru...@gmail.com on 3 Jul 2008 at 5:03

GoogleCodeExporter commented 9 years ago 
Right, the URL handling is quite 'stupid' right now, it just looks for 
whitespace to
end the URL. It should look for any character not valid in a URL.

Original comment by paulburt...@gmail.com on 3 Jul 2008 at 5:43

GoogleCodeExporter commented 9 years ago 
( is not valid in URL, but sometimes it is used (changed into entity).

so it's not validity case...

Original comment by jakub.ru...@gmail.com on 3 Jul 2008 at 6:17

GoogleCodeExporter commented 9 years ago 
When we come accross a bracket in a URL the URL should end, if there is a 
bracket in
the URL it will be hex encoded (a html entity) and therefore no longer be a 
bracket
as far as MessageUtility is concerned. Trust me, I know what I'm talking 
about...

Original comment by paulburt...@gmail.com on 3 Jul 2008 at 6:30

GoogleCodeExporter commented 9 years ago 
ugh, I noticed little mistake in my first message.

should → shouldn't.

Original comment by jakub.ru...@gmail.com on 3 Jul 2008 at 6:42

GoogleCodeExporter commented 9 years ago 
So what are we doing with this?

Original comment by dra...@gmail.com on 9 Jul 2008 at 4:33

GoogleCodeExporter commented 9 years ago

Original comment by dra...@gmail.com on 11 Jul 2008 at 2:30

GoogleCodeExporter commented 9 years ago

Original comment by dra...@gmail.com on 11 Jul 2008 at 2:31

GoogleCodeExporter commented 9 years ago 
0.7.4 is already released

Original comment by paulburt...@gmail.com on 13 Jul 2008 at 4:36

GoogleCodeExporter commented 9 years ago 
it seems you changed something.

URL is not URL. see:

http://liviopl.jogger.pl/2008/07/16/pytanie-o-joggerowe-tagi/

that string is a URL, but it looks so:

http://img.wklej.org/images/776772602galax-chat.png

Original comment by jakub.ru...@gmail.com on 16 Jul 2008 at 11:04

GoogleCodeExporter commented 9 years ago 
That URL should be fixed in trunk. We pretty much now have a whitelist of 
allowed
characters for URLs, we just need to make sure all of the valid characters are 
on it.

Original comment by paulburt...@gmail.com on 16 Jul 2008 at 9:02

GoogleCodeExporter commented 9 years ago 
Shouldn't this already be closed?

Original comment by Zarevucky.Jiri on 14 Feb 2009 at 9:11

GoogleCodeExporter commented 9 years ago 
Haven't tried yet. Wait for me response, I'll try it tomorrow.

Original comment by jakub.ru...@gmail.com on 14 Feb 2009 at 9:49

GoogleCodeExporter commented 9 years ago 
As paul mentioned in his last post, there could still be characters missing 
from the
whitelist.

I think that is why this is still opened.

Original comment by dra...@gmail.com on 15 Feb 2009 at 4:46

GoogleCodeExporter commented 9 years ago 
Anyway, whitelist is never going to be complete. URL can contain 
culture-specific
characters. See http://en.wikipedia.org/wiki/Internationalized_domain_name

Original comment by Zarevucky.Jiri on 15 Feb 2009 at 5:22

GoogleCodeExporter commented 9 years ago 
Perhaps blacklist would be more appropriate?

Original comment by Zarevucky.Jiri on 15 Feb 2009 at 5:28

GoogleCodeExporter commented 9 years ago

Original comment by dra...@gmail.com on 20 May 2009 at 2:50