zD12 / galaxium

Automatically exported from code.google.com/p/galaxium
0 stars 0 forks source link

"No personal message" in contact list #276

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Open Galaxium, connect to msn network.

What is the expected output? What do you see instead?
For contacts that doesn't have a "personal message", instead of nothing, in
the contact list says "No personal message".
IMO, would be much cleaner, if the user doesn't have a personal message,
show nothing at all in that field.

Galaxium 0.8, sv 1142, ubuntu hardy 64bits, mono 1.9.1.

Please provide any additional information below.

Original issue reported on code.google.com by pipi...@gmail.com on 11 Jul 2008 at 9:14

Attachments:

GoogleCodeExporter commented 9 years ago
I proposed disabling text, but my issue was marked as INVALID, so if this one 
would
be marked so not, it would be hypocrisy...

Original comment by jakub.ru...@gmail.com on 12 Jul 2008 at 2:32

GoogleCodeExporter commented 9 years ago
So then, what would you propose for the text placement?

If there is 1 line missing, you will either have a blank space for each contact
there, or you will move the text and center it for each contact, making more 
white
space in between each row.

Original comment by dra...@gmail.com on 12 Jul 2008 at 3:31

GoogleCodeExporter commented 9 years ago
Personally I'd say leave the text for normal & detailed views, but remove it 
for compact.

Original comment by paulburt...@gmail.com on 12 Jul 2008 at 4:43

GoogleCodeExporter commented 9 years ago
I would leave the field with an empty space, and the rest of the text in the 
same
position.
Why I think this text should go?:
1. It's a bit redundant, if there is nothing there.., it's because the user 
doesn't
has a Personal Message (PM). It's self explanatory.
2. When most of your contacts doesn't have a PM, the contact list looks 
strange..,
(don't find the proper word), with all these on your list:

No personal message
No personal message
No personal message
No personal message
No personal message

, sometimes that message it's even larger than the contact nickname!.., which 
is a
bit intrusive and make difficult to read.

well.., all that IMO.

Regards,

Original comment by pipi...@gmail.com on 14 Jul 2008 at 1:37

GoogleCodeExporter commented 9 years ago
Or maybe something more in the appearance of this? None of Linux IM can provide 
this..

http://ekipa.tlen.pl/s/p/pliki/15/1508/1508_d.jpg

If someone don't have personal message, there is no space for the message.
And personal message wrapping to next line with clickable links will be a great
fuctions for me :)

Original comment by skoru...@gmail.com on 17 Jul 2008 at 8:16

GoogleCodeExporter commented 9 years ago
Well.., what u mean? providing a link when the contact has a url in their 
nickname/PM
?. If it's that, actually emesene does it, adds an option in the contextual menu
(hover contact) that opens the link with default browser. But I agree.., would 
be a
great feature.

Original comment by pipi...@gmail.com on 17 Jul 2008 at 8:40

GoogleCodeExporter commented 9 years ago
Here I'm attaching an example to compare. I've just downloaded latest svn copy, 
and
changed a couple of lines an here is how it looks.., doesn't looks simpler?.

Cheers,
Pedro

Original comment by pipi...@gmail.com on 17 Jul 2008 at 9:16

Attachments:

GoogleCodeExporter commented 9 years ago
imho screenshot3 looks really better than screenshot4.
Maybe it should be considered to include this "feature" in Galaxium, as it 
really
tidies up the Interface

Original comment by Pano...@gmx.de on 23 Jul 2008 at 4:35

GoogleCodeExporter commented 9 years ago
Here I'm attaching a patch, which changes that behaviour with the personal 
message.

SVN revision: 1200.
Author: Pedro Guridi.

The patches changes the files:

src/Galaxium.Protocol.Jabber.Gtk/JabberContactTreeManager.cs
src/Galaxium.Protocol.Jabber.Gtk/JabberChatWidget.cs
src/Galaxium.Protocol.GaduGadu.GtkGui/GaduChatWidget.cs
src/Galaxium.Protocol.Msn.Gtk/MsnContactTreeManager.cs
src/Galaxium.Protocol.Aim.Gtk/AimChatWidget.cs
src/Galaxium.Gui.Gtk/Widgets/BasicChatWidget.cs
src/Galaxium.Gui.Gtk/Widgets/GroupChatWidget.cs

To apply the patch, download a svn copy an run this within the 
"galaxium-read-only"
directory: patch -p0 < pm-patch.patch

regards

Original comment by pipi...@gmail.com on 25 Aug 2008 at 6:48

Attachments:

GoogleCodeExporter commented 9 years ago
I propose two things:

  a) The string (if present) should be in one globally accessible property, so change
in one place will change all occurrences.
  b) If present, it should be settable by user. Someone can want "No personal
message.", others "No status message.", most probably just an empty space.

Are there any problems with such behavior? Sure, it will add one more settings 
entry,
but the entire settings is already so bloated it needs a major refit anyway.

Original comment by Zarevucky.Jiri on 9 Feb 2009 at 4:04

GoogleCodeExporter commented 9 years ago
Um, well sure it can be a global string that shows up the same way in all 
protocols. And there could be an option to omit the message completely.

About the settings being bloated, what do you mean?

Original comment by dra...@gmail.com on 9 Feb 2009 at 10:20

GoogleCodeExporter commented 9 years ago
Well, as I look now, not the entire settings. But in the interface options, 
there are
many checkboxes, unaligned and seemingly randomly ordered. Especially the last 
tab is
a complete chaos.

Original comment by Zarevucky.Jiri on 10 Feb 2009 at 6:17

GoogleCodeExporter commented 9 years ago
This issue was about the "No personal message" string, which is gone now anyway.

Closing issue.

Original comment by dra...@gmail.com on 20 May 2009 at 4:57