Closed GoogleCodeExporter closed 9 years ago
This is a test patch to test
https://groups.google.com/d/msg/pircbotx/iTkdcdAHUEI/O6UyIKyZMioJ
Original comment by Lord.Qua...@gmail.com
on 6 Aug 2014 at 1:52
Attachments:
Due to the design of PircBotX this is a fairly complex issue. The fix in
Revision 170d103136f9 is temporary until I can re-structure InputParser in 2.2.
I'm copying my explanation from
Configuration.Builder.setWhoisFailedTrackingEnabled() :
When a WHOIS request fails, the servers sends back a generic 401
(ERR_NOSUCHNICK) and 318 (RPL_ENDOFWHOIS). However 401 is also used for failed
PMs and other commands that are targeted to a nick. PircBotX's current design
is unable to link a sent command and it's response, so upon encountering a 401
it doesn't know if it's a failed WHOIS, a failed PM, or something else
The temporary fix is to track all 401's as potential failed WHOIS requests and
remove any that have a 318 following. But now there's a memory leak if there
are any 401's that aren't failed WHOIS requests. Most bots should not be
affected but for convenience this workaround can be disabled.
By default this is enabled
Original comment by Lord.Qua...@gmail.com
on 8 Aug 2014 at 2:37
Original issue reported on code.google.com by
jzhou2...@gmail.com
on 29 Jul 2014 at 8:04