zDevelopers / ImageOnMap

Repo for ImageOnMap, a bukkit plugin created to display any image using a map
https://dev.zcraft.fr/imageonmap
Other
190 stars 102 forks source link

Maptool explore & other commands doesn't work #172

Open illumeleet opened 3 years ago

illumeleet commented 3 years ago

After using /maptool explore command this message appears: image Same issue with these commands: /maptool get (map) /maptool delete (map). The only few commands that work are maptool new & maptool rename Issuing maptool list causes error in console: image

Vlammar commented 3 years ago

This player doesn't exist. That's why this doesn't work. But I got one time the issue with the list. I'm still investigating the issue

illumeleet commented 3 years ago

How is that possible? The command is being executed by player.

This player doesn't exist.

Vlammar commented 3 years ago

https://fr.namemc.com/search?q=Profo228 he doesn't exist for namemc too

illumeleet commented 3 years ago

So the plugin won't work on servers using online-mode false?

Vlammar commented 3 years ago

If the player is logged on your server that should work (if bukkit is able from a name to give an uuid) (I will check tonight if it's something missing or if it's an issue from bukkit.getofflineplayer that don't work with off-line server)

illumeleet commented 3 years ago

Okay, thanks! Waiting for your reply.

illumeleet commented 3 years ago

Just noticed "Cannot reproduce" tag. Well, the issue is you're using in your api mojang's servers to fetch player's UUID, so, if there's no license account with such nickname, it fails to retrieve UUID, which is a big issue for online-mode=false servers. If you use bukkit's methods to get UUID, everything works exactly as expected

Vlammar commented 3 years ago

Bukkit's methods are a bit more trickier than this. bukkit.getPlayer(UUID) only return player that is actually connected, else null bukkit.getPlayer(UUID) return an Offlineplayer that connected once, lastly we try to retrieve from mojang the player UUID if no player is known. I didn't managed to replicate this, when I got time I will try with the offline mode. Thanks for the idea