search

zDevelopers / ImageOnMap

Repo for ImageOnMap, a bukkit plugin created to display any image using a map
https://dev.zcraft.fr/imageonmap
Other
191 stars 102 forks source link

Paper 1.18.2 /tomap error "CraftItem failed" #255

Open ZerpCraft opened 2 years ago

ZerpCraft commented 2 years ago

Plugin version is 4.2.2 Command run: /tomap https://i.imgur.com/hfn0QMe.png Other notes: After the error, the item frames turn invisible. Screenshot attached. Notice in the screenshot that on the right hand side the readout says I'm still looking at an Item_frame [entity.] 2022-03-05_09 12 49

Stack Trace:

fr.zcraft.imageonmap.quartzlib.tools.reflection.NMSException: Cannot set item stack tags
INFO at fr.zcraft.imageonmap.quartzlib.components.nbt.NBT.addToItemStack(NBT.java:241) ~[ImageOnMap-4.2.2.jar:?]
INFO at fr.zcraft.imageonmap.quartzlib.tools.items.ItemStackBuilder.craftItem(ItemStackBuilder.java:264) ~[ImageOnMap-4.2.2.jar:?]
INFO at fr.moribus.imageonmap.ui.SplatterMapManager.lambda$placeSplatterMap$1(SplatterMapManager.java:311) ~[ImageOnMap-4.2.2.jar:?]
INFO at org.bukkit.craftbukkit.v1_18_R2.scheduler.CraftTask.run(CraftTask.java:101) ~[paper-1.18.2.jar:git-Paper-224]
INFO at org.bukkit.craftbukkit.v1_18_R2.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:483) ~[paper-1.18.2.jar:git-Paper-224]
INFO at net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:1521) ~[paper-1.18.2.jar:git-Paper-224]
INFO at net.minecraft.server.dedicated.DedicatedServer.tickChildren(DedicatedServer.java:483) ~[paper-1.18.2.jar:git-Paper-224]
INFO at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1444) ~[paper-1.18.2.jar:git-Paper-224]
INFO at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1218) ~[paper-1.18.2.jar:git-Paper-224]
INFO at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:317) ~[paper-1.18.2.jar:git-Paper-224]
INFO at java.lang.Thread.run(Thread.java:833) ~[?:?]
INFO Caused by: fr.zcraft.imageonmap.quartzlib.tools.reflection.NMSException: Unable to retrieve NBT data
INFO at fr.zcraft.imageonmap.quartzlib.components.nbt.NBT.fromItemStack(NBT.java:77) ~[ImageOnMap-4.2.2.jar:?]
INFO at fr.zcraft.imageonmap.quartzlib.components.nbt.NBT.addToItemStack(NBT.java:211) ~[ImageOnMap-4.2.2.jar:?]
INFO ... 10 more
OoLunar commented 2 years ago

You are welcome to recompile and upload if you are not content with how I did so /nm

J-eremy commented 2 years ago

You are welcome to recompile and upload if you are not content with how I did so /nm

nope, been there done that didn't work out well. lmfao. Just giving you a heads up that is all.

Nowaha commented 2 years ago

I have released a temporary fix, with source, for 1.18.2 users at https://github.com/Nowaha/ImageOnMap/releases/tag/4.2.3

synrg commented 2 years ago

@Nowaha Thanks. Seems to work. Note: version still reports as 4.2.2 when it starts up.

kotarobo commented 2 years ago

@Nowaha Existing maps appear to no longer be displayed. It may be necessary to convert them.

Newly registered ones are displayed.