search

zHaytam / SmartBreadcrumbs

A utility library for ASP.NET Core (both MVC and Razor Pages) websites to easily add and customize breadcrumbs.
https://blog.zhaytam.com/2018/06/24/asp-net-core-using-smartbreadcrumbs/
MIT License
161 stars 77 forks source link

Multiple inheritance of Controller #1

Closed fairking closed 6 years ago

fairking commented 6 years ago

Found some small issues, please take a look at screenshot bellow. My controllers are a bit complex. 

public abstract class BaseController : Controller
public abstract class ViewController : BaseController
public class HomeController : ViewController

The same issue might happen with return types (IActionResult, Task<IActionResult>) It can be JsonResult for example or some CustomResult.

untitled111

Thanks for your little component which does a huge job. Regards.

fairking commented 6 years ago

My fixes below. There are more than described in the Issue. SmartBreadcrumbs.zip

fairking commented 6 years ago

Some more fixes: SmartBreadcrumbs2.zip

Tested in my project. working perfectly.

zHaytam commented 6 years ago

Thanks, I'll look at this asap!

zHaytam commented 6 years ago

Pushed your modifications and uploaded the new version to nuget, it should be available shortly. Thanks again!

fairking commented 6 years ago

No problem my friend. I am working on MenuTagHelper. Looking forward to share my code if you are interesting.