Fixes #23 ArgumentException When Decorating Action Overload(s)

zHaytam / SmartBreadcrumbs

A utility library for ASP.NET Core (both MVC and Razor Pages) websites to easily add and customize breadcrumbs.

https://blog.zhaytam.com/2018/06/24/asp-net-core-using-smartbreadcrumbs/

MIT License

161 stars 77 forks source link

Fixes #23 ArgumentException When Decorating Action Overload(s) #30

Closed ConnerOrth closed 5 years ago

ConnerOrth commented 5 years ago

allows identical methodnames as long as they differ in httpmethod, assumes GET is the default, otherwise looks at httpmethodAttributes.

zHaytam commented 5 years ago

It's really weird, the commit "-added DefaultAction to BreadcrumbOptions. …" is still being added even though your last PR was already merged...

ConnerOrth commented 5 years ago

Yeah i made an error locally. So i locally reverted the error which is why you see the commit mentioned. But if you look at the file changes you can see its actually the changes that fix #23

zHaytam commented 5 years ago

Ah, yes indeed. I will merge this and update NuGet this evening.

ConnerOrth commented 5 years ago

Thanks, hope it will help others.