search

zMarch / Orc

Orc is a post-exploitation framework for Linux written in Bash
MIT License
390 stars 51 forks source link

Use "ip a" instead of "ifconfig" #77

Closed q2dg closed 5 years ago

q2dg commented 5 years ago

net-tools package (where ifconfig, netstat, route...commands belong) is deprecated and not installed by default in increasingly more distributions. Thanks

UlrichBerntien commented 5 years ago

I think Orc should support old and new systems.

Inside the Orc file is the section "Compatibility Layer". The functions in this layer should check which program (ip or ifconfig) exists, then calling the existing program. Function "orc_existsProg" does the check.

See for example the orc_listBroadcastAddress function. If ip exists, then the ip command is used else the old ifconfig is used.

Checking the usage of ifconfig during writing this message I found a bug in line 948. I will fixed the bug soon. All other usages of ifconfig should be inside a check. Update 19:50: in line 948 "ifconfig" is the basename of a file, not a command. So also in this code area is a check for exists ifconfig before calling ifconfig.

If you found another usage of ifconfig without a check before, please report the bug,

q2dg commented 5 years ago

Ok. Thanks for your so clear explanation. I'll close the issue, then. Thanks!