search

zPeanut / Hydrogen

An open source, mixin based ghost client for Minecraft 1.8.9 built on Minecraft Forge.
MIT License
147 stars 17 forks source link

Tab Menu (Player List) Darkens Enchantment Glint #46

Closed tanyachaff closed 2 years ago

tanyachaff commented 2 years ago

Describe the bug If the tab menu is held, enchantment glints will invert (darken).

To Reproduce Steps to reproduce the behavior:

  1. Place an item with enchantment glint in hotbar.
  2. Hold tab, and observe the item.

Expected behavior The glint should remain the same.

Actual behavior The glint darkens, along with sections of the hotbar.

Desktop (please complete the following information):

zPeanut commented 2 years ago

will look into this, probably a problem with the implementation of the old tab system with the animations module. did you happen to have the animations module on during your observation?

tanyachaff commented 2 years ago

No, regardless of animations being on/off this still occured

zPeanut commented 2 years ago

https://user-images.githubusercontent.com/25800857/151794548-3720f140-78e1-410f-9b5e-0b6eca37b674.mp4

i honestly cant seem to reproduce this bug

tanyachaff commented 2 years ago

Apologies, this seems to be a conflict with the mod better tab 2.1. Strangely enough I wasn't having this issue prior to upgrading from version 1.9 to 1.12 though.

Closing as it may be nicer to include this mod's functionality within the client instead of fixing a one-off