zPeanut / Hydrogen

An open source, mixin based ghost client for Minecraft 1.8.9 built on Minecraft Forge.
MIT License
146 stars 15 forks source link

Random crashes in singleplayer (not tried multiplayer yet) #51

Closed Sobek88 closed 2 years ago

Sobek88 commented 2 years ago

I was testing the client in singleplayer Minecraft and noticed that the key to open up the GUI was LSHIFT. I tried to bind it to RSHIFT, which is the traditional GUI key, but when I attempted to rebind the key, my game crashed. The crash report is attached. crash-2022-04-14_10.00.58-server.txt

zPeanut commented 2 years ago

use .bind module key for now, ill look into this

zPeanut commented 2 years ago

if the bind command still doesnt work (i've had problems sometimes assigning it to keys such as LCONTROL), you can change the clickgui bind manually in the modules.json folder located at .minecraft\Hydrogen\, by searching for "ClickGUI" and changing the "keybind" value to 54.

it should look something like this: image

Sobek88 commented 2 years ago

Thanks!

Sobek88 commented 2 years ago

Update: the crash happening when I attempted to change the GUI keybind was a coincidence. The game just randomly crashes and says there was a ConcurrentModificationException.

Here are three more crash logs: crash-2022-04-15_09.21.27-server.txt crash-2022-04-15_09.28.48-server.txt crash-2022-04-15_09.10.43-server.txt

zPeanut commented 2 years ago

this seems to be caused by a ConcurrentModificationException, meaning the module arraylist is being iterated through somewhere else. this is fixed by synchronizing threads. i however have not been able to encounter this bug yet. if i (or you for that matter) can find a way to reproduce the bug 100% of the time (so i can check that its fully fixed), i can push a quick hotfix out.

master7720 commented 2 years ago

I was testing the client in singleplayer Minecraft and noticed that the key to open up the GUI was LSHIFT. I tried to bind it to RSHIFT, which is the traditional GUI key, but when I attempted to rebind the key, my game crashed. The crash report is attached. crash-2022-04-14_10.00.58-server.txt

Wow your so smart your suppose to use it in MULTIPLAYER NOT SIGNLE PLAYER THATS WHY IT CRASHES

zPeanut commented 2 years ago

lol it probably crashes in multiplayer too, its not related to SP or MP ?XD

Sobek88 commented 2 years ago

Wow your so smart your suppose to use it in MULTIPLAYER NOT SIGNLE PLAYER THATS WHY IT CRASHES

BRO I WANTED TO TEST IT BEFORE HACKING ON NERDS IN COPS N' CRIMS

lmao skeletons can spawn on hypixel too so I'm gonna crash either way

zPeanut commented 2 years ago

bro cops and crims is goated tho

Sobek88 commented 2 years ago

no one would be able to hit me bc i be zoomin xD

also esp op in cops and crims

zPeanut commented 2 years ago

should be fixed in 1.12.4