search

zRedShift / mimemagic

Powerful and versatile MIME sniffing package using pre-compiled glob patterns, magic number signatures, XML document namespaces, and tree magic for mounted volumes, generated from the XDG shared-mime-info database.
GNU General Public License v2.0
99 stars 10 forks source link

modules: fix: version 2.0.0 is not installable via go-tooling #8

Closed fho closed 2 years ago

fho commented 2 years ago

A git tag and github release was created for a version 2.0.0 but the version was not installable via go tools and could not be added as dependency to a go.mod file.

For Major version >1 the version must be appended to the import path. This was missing. (see https://github.com/golang/go/wiki/Modules#releasing-modules-v2-or-higher for more information)

Append /v2 to the import path, change all references accordingly. The retract directives for minor versions of v1 are removed. They can only be defined in the go.mod file for the same major version.

nocive commented 2 years ago

ping @zRedShift

fho commented 2 years ago

Version 2.0.0 might have to be retracted in the next version. I'm not sure because v2 never really worked because the mod path was wrong.